Adblock.ini 2500 lines bug

Iron Forum for english speaking people

frozengrad
Posts: 1
Joined: Sun Mar 07, 2010 3:36 am

Adblock.ini 2500 lines bug

Post by frozengrad »

Hi,

I'm using Iron 4.0.280

I've noticed that only first 2500 lines of adblock.ini actually work. Everything written after has no effect.
Scorpius
Posts: 3
Joined: Mon Mar 08, 2010 4:31 am

Re: Adblock.ini 2500 lines bug

Post by Scorpius »

I can confirm this happens to me too.

After hours of trying to figure out why if I put my own rules at the end of the adblock.ini file they didn't work but they do if I put them in the first lines, I realized this bug as well.

Since fanbdoy's adblock.ini for Iron is way over 2500 lines this is kinda important to fix.
crisp
Posts: 1
Joined: Thu Mar 11, 2010 10:26 am

Re: Adblock.ini 2500 lines bug

Post by crisp »

Another issue I discovered is using comments after the initial comment block, for example:

# comment line 1
# comment line 2
adblockline1
adblockline2
# comment line 3

This in fact starts blockings URL's that contain "#" characters in them (which happens frequently) -- apparently the third line is not seen as a comment but as an adblock rule.
jerrytouille
Posts: 23
Joined: Sun Feb 28, 2010 12:08 am

Re: Adblock.ini 2500 lines bug

Post by jerrytouille »

does the latest alpha 5.0 version fix this already?
User avatar
SRWare
Site Admin
Posts: 3247
Joined: Sat Jan 19, 2008 4:16 am

Re: Adblock.ini 2500 lines bug

Post by SRWare »

this will be fixed soon!
Iron-Updates via Twitter: http://twitter.com/srware

Donations via Paypal and Bitcoin:
http://iron-start.com/spenden.php
jerrytouille
Posts: 23
Joined: Sun Feb 28, 2010 12:08 am

Re: Adblock.ini 2500 lines bug

Post by jerrytouille »

SRWare wrote:this will be fixed soon!
GREAT! Also a short wiki section about the syntax of adblock.ini would be nice too. Thanks!
User avatar
SRWare
Site Admin
Posts: 3247
Joined: Sat Jan 19, 2008 4:16 am

Re: Adblock.ini 2500 lines bug

Post by SRWare »

Iron-Updates via Twitter: http://twitter.com/srware

Donations via Paypal and Bitcoin:
http://iron-start.com/spenden.php
jerrytouille
Posts: 23
Joined: Sun Feb 28, 2010 12:08 am

Re: Adblock.ini 2500 lines bug

Post by jerrytouille »

downloading rite now. everyone plz joined the test! This is a great patch if it works!

Thanks Mr. Smith :)
jerrytouille
Posts: 23
Joined: Sun Feb 28, 2010 12:08 am

Re: Adblock.ini 2500 lines bug

Post by jerrytouille »

ok tested for 10 mins and it works so far. will post more update. by the way 2 questions:
1. will the length of the list affect the mem usage and performance of Iron?
2. does this fix the comment # issue mentioned in other thread?
Again, thanks for the good work :D
User avatar
SRWare
Site Admin
Posts: 3247
Joined: Sat Jan 19, 2008 4:16 am

Re: Adblock.ini 2500 lines bug

Post by SRWare »

jerrytouille wrote: 1. will the length of the list affect the mem usage and performance of Iron?
2. does this fix the comment # issue mentioned in other thread?
1. Maybe a little...you have to test it for yourself...up to now nobody had problems with a "long list"
2. this will be fixed as next
Iron-Updates via Twitter: http://twitter.com/srware

Donations via Paypal and Bitcoin:
http://iron-start.com/spenden.php
Post Reply