Page 1 of 2

Adblock.ini 2500 lines bug

Posted: Sun Mar 07, 2010 4:08 am
by frozengrad
Hi,

I'm using Iron 4.0.280

I've noticed that only first 2500 lines of adblock.ini actually work. Everything written after has no effect.

Re: Adblock.ini 2500 lines bug

Posted: Mon Mar 08, 2010 4:34 am
by Scorpius
I can confirm this happens to me too.

After hours of trying to figure out why if I put my own rules at the end of the adblock.ini file they didn't work but they do if I put them in the first lines, I realized this bug as well.

Since fanbdoy's adblock.ini for Iron is way over 2500 lines this is kinda important to fix.

Re: Adblock.ini 2500 lines bug

Posted: Thu Mar 11, 2010 10:34 am
by crisp
Another issue I discovered is using comments after the initial comment block, for example:

# comment line 1
# comment line 2
adblockline1
adblockline2
# comment line 3

This in fact starts blockings URL's that contain "#" characters in them (which happens frequently) -- apparently the third line is not seen as a comment but as an adblock rule.

Re: Adblock.ini 2500 lines bug

Posted: Sat Mar 13, 2010 6:06 am
by jerrytouille
does the latest alpha 5.0 version fix this already?

Re: Adblock.ini 2500 lines bug

Posted: Sat Mar 13, 2010 3:40 pm
by SRWare
this will be fixed soon!

Re: Adblock.ini 2500 lines bug

Posted: Sat Mar 13, 2010 5:04 pm
by jerrytouille
SRWare wrote:this will be fixed soon!
GREAT! Also a short wiki section about the syntax of adblock.ini would be nice too. Thanks!

Re: Adblock.ini 2500 lines bug

Posted: Mon Mar 15, 2010 12:45 pm
by SRWare

Re: Adblock.ini 2500 lines bug

Posted: Mon Mar 15, 2010 3:14 pm
by jerrytouille
downloading rite now. everyone plz joined the test! This is a great patch if it works!

Thanks Mr. Smith :)

Re: Adblock.ini 2500 lines bug

Posted: Mon Mar 15, 2010 3:47 pm
by jerrytouille
ok tested for 10 mins and it works so far. will post more update. by the way 2 questions:
1. will the length of the list affect the mem usage and performance of Iron?
2. does this fix the comment # issue mentioned in other thread?
Again, thanks for the good work :D

Re: Adblock.ini 2500 lines bug

Posted: Mon Mar 15, 2010 4:04 pm
by SRWare
jerrytouille wrote: 1. will the length of the list affect the mem usage and performance of Iron?
2. does this fix the comment # issue mentioned in other thread?
1. Maybe a little...you have to test it for yourself...up to now nobody had problems with a "long list"
2. this will be fixed as next